Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4130: Add styles for data-editor-highlight #343

Merged
merged 2 commits into from
Nov 7, 2023
Merged

GN-4130: Add styles for data-editor-highlight #343

merged 2 commits into from
Nov 7, 2023

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented Nov 2, 2023

Overview

GN-4130: Move styles for data-editor-highlight

Styles that were applied to elements with the data-editor-highlight attribute (used by citation-plugin) moved from editor repository to ember-rdfa-editor-lblod-plugins as part of the citation-plugin.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4130

Setup

  1. Checkout GN-4130: Add styles for data-editor-highlight #343
  2. Checkout GN-4130: Remove styles for data-editor-highlight ember-rdfa-editor#1013
  3. Build ember-rdfa-editor
  4. yalc publish the ember-rdfa-editor
  5. yalc add @lblod/ember-rdfa-editor inside ember-rdfa-editor-lblod-plugins

How to test/reproduce

Confirm that styling is still shown correctly for inline citation search, note the styles on "hello" word in the below screenshot

CleanShot 2023-11-02 at 11 21 27@2x

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@abeforgit abeforgit merged commit e9b428c into master Nov 7, 2023
2 checks passed
@abeforgit abeforgit deleted the GN-4130 branch November 7, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants