Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ember 4.8 #372

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

elpoelma
Copy link
Collaborator

@elpoelma elpoelma commented Jan 15, 2024

Overview

This PR drops support for ember 4.8.
The supported ember-source version range is now ^4.12.0
Ember 5.x is not yet officially supported.

Additionally, this PR also pins the ember-source devdep to the lowest supported version (4.12.0).

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma merged commit 1ce6396 into master Jan 15, 2024
2 checks passed
@elpoelma elpoelma deleted the breaking/drop-ember-4.8-support branch January 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant