Hide template comments when publishing #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Uses editor from the relevant PR, but does not actually depend on it as this would break backwards compatibility.
connected issues and PRs:
Editor PR: lblod/ember-rdfa-editor#1219
Jira ticket: binnenland.atlassian.net/browse/GN-4999
Setup
For the second part of the testing, you'll need to link to the PR version of the editor, e.g. by setting the dependency to be
10.5.0-dev.7f01e7e07f7de4b7cef5870bbcffeed2b7589674
How to test/reproduce
There are two parts to testing this:
Challenges/uncertainties
Backwards compatibility makes the imports a mess...
Checks PR readiness