Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide template comments when publishing #483

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

piemonkey
Copy link
Collaborator

Overview

Uses editor from the relevant PR, but does not actually depend on it as this would break backwards compatibility.

connected issues and PRs:

Editor PR: lblod/ember-rdfa-editor#1219
Jira ticket: binnenland.atlassian.net/browse/GN-4999

Setup

For the second part of the testing, you'll need to link to the PR version of the editor, e.g. by setting the dependency to be 10.5.0-dev.7f01e7e07f7de4b7cef5870bbcffeed2b7589674

How to test/reproduce

There are two parts to testing this:

  1. As-is, the template comment node functions exactly as before.
  2. With the PR version of the editor, the new export for publish button in the debug tools shows a version without template comments. The existing export buttons work as before.

Challenges/uncertainties

Backwards compatibility makes the imports a mess...

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants