Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset person edit modal on close #488

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 16, 2024

Overview

Reset the person edit modal so it doesn't show old filtered data when it's open again

connected issues and PRs:

GN-5096

Setup

You must have a working vendor proxy service in the backend, or you can test linking the plugins to GN-frontend and proxying that to dev, let me know if you need any help

How to test/reproduce

Insert 2 person variable nodes in the RB part, then swich to the GN part and try to edit them, you should be able to filter on one, close the modal and open the same one or the other and the filter will be cleared and the data refreshed

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only resets the search the second time modal is opened
so:

  • open modal
  • enter search, table updates
  • insert mandatee
  • select a different place in the doc
  • open modal again
  • observe table is still filtered
  • close modal without inserting (if you insert here, the modal still doesn't reset)
  • open again: now table is reset

@lagartoverde
Copy link
Contributor Author

only resets the search the second time modal is opened so:

  • open modal
  • enter search, table updates
  • insert mandatee
  • select a different place in the doc
  • open modal again
  • observe table is still filtered
  • close modal without inserting (if you insert here, the modal still doesn't reset)
  • open again: now table is reset

Yes my bad, I was resetting every time the modal is close, but the insert was closing the modal without using the function, I solved that

@abeforgit abeforgit merged commit 8f665b9 into master Oct 20, 2024
2 of 3 checks passed
@abeforgit abeforgit deleted the bugfix/reset-person-edit-modal branch October 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants