Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse only article also from templates #490

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 21, 2024

Overview

Now the only article attr is also parsed from templates and added it to the templates stored in the test app

connected issues and PRs:

GN-5113

Setup

None

How to test/reproduce

Insert a template with an article like besluit template and check that it correctly shows enig article

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Oct 21, 2024
@lagartoverde lagartoverde added the bug Something isn't working label Oct 21, 2024
@abeforgit abeforgit merged commit 816bb59 into master Oct 24, 2024
3 checks passed
@abeforgit abeforgit deleted the bugfix/parse-only-article branch October 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants