Snippet placeholder redesign #496
Merged
+253
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snippet placeholder node now uses the snippet nodeview component, which in turn shows the snippet placeholder component if relevant. This allows for code re-use between the two for inserting snippets
piemonkey
force-pushed
the
feat/snippet-placeholder-redesign
branch
from
3f79e36
to
2e3c09f
Compare
lagartoverde
requested changes
Nov 7, 2024
|
@elpoelma are you looking at these comments or should I? |
You can do it if you want :) I am currently working on an editor PR which fixes the specificity css styling regression which should remove the need of the |
* Add snippet list names to the modal title * add quotes to the snippet names linting and changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Continued a little of the refactoring from replacing the snippet placeholder, so that the snippet placeholder component is now used inside a snippet component. This means that I could re-use the insert logic from the snippet buttons and if we wanted in the future we could include buttons in the same style as for inserted snippets. Since I was not including buttons for now, I was able to use @elpoelma 's redesign implementation work almost untouched.
For consistency, I move the snippet list ids information to RDFa for inserted snippet nodes.
connected issues and PRs:
Builds on #495
Jira ticket: https://binnenland.atlassian.net/browse/GN-5117
Setup
N/A
How to test/reproduce
Insert, replace, delete snippets and snippet placeholders with different configurations and make sure everything works as expected. The expected interactivity is different depending on which sample page:
Challenges/uncertainties
N/A
Checks PR readiness