Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of basic support for ember-mu-login. #5

Merged
merged 21 commits into from
Jul 6, 2022

Conversation

elpoelma
Copy link
Contributor

This PR introduces support for ember-mu-login on the 'login'-route. If this would be preferred, I can add a variable to environment.js in order to configure the default route (login or mock-login). Styling still needs to be added.

@elpoelma elpoelma added the enhancement New feature or request label Jun 30, 2022
Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a good idea to include the login service in the deploying section of the readme

Base automatically changed from ember-upgrade-3.28 to development July 6, 2022 13:44
@@ -10,8 +10,4 @@ export default class LoginRoute extends Route {
refreshModel: true,
},
};

beforeModel() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should have been removed

@nvdk nvdk merged commit 5ace05f into development Jul 6, 2022
@nvdk nvdk deleted the feature/ember-mu-login branch July 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants