Pass component classes to variable plugin instead of component names #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
force-pushed
the
chore/component-helper-removal
branch
from
3416d7e
to
9794667
Compare
elpoelma
changed the base branch from
master
to
internal/update-editor-packages
|
@piemonkey I think we can close this PR as it is superseded by #179? |
|
@elpoelma Sorry to have missed this. I don't have a strong preference, but since this is necessary and non-breaking and #179 has more potential for problems and contains the same commits, I'd say we should merge this one. That way any other work can be based on this version and #179 is just a slightly smaller PR. |
7 tasks
Bumps [eslint-plugin-qunit](https://github.com/platinumazure/eslint-plugin-qunit) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/platinumazure/eslint-plugin-qunit/releases) - [Changelog](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/CHANGELOG.md) - [Commits](platinumazure/eslint-plugin-qunit@v8.0.0...v8.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-qunit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: x-m-el <[email protected]>
Co-authored-by: x-m-el <[email protected]>
Co-authored-by: x-m-el <[email protected]>
this is to make sure it's not picked up by default for anything
Don't ask me why this works and other configs don't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update to support plugins which don't use component-helper, so we pass in components.
Do not merge until the plugins version number is increased to one that includes this change (should be v15).Plugins v15 now included.connected issues and PRs:
lblod/ember-rdfa-editor-lblod-plugins#323
Setup
N/A
How to test/reproduce
Can still insert all the different variable types into a document.
Challenges/uncertainties
N/A
Checks PR readiness