Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agendapoint numbers to download table #759

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Nov 6, 2024

Overview

Add agendapoint numbers to download table
Also changed the way the headers looked, as they had the style of a sortable header without being sortable

connected issues and PRs:

GN-5177

Setup

None

How to test/reproduce

Go to the download table and see that the agendapoint number now appears on the left column

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde requested review from abeforgit, elpoelma and piemonkey and removed request for abeforgit and elpoelma November 6, 2024 15:56
@lagartoverde lagartoverde self-assigned this Nov 6, 2024
@lagartoverde lagartoverde added the enhancement New feature or request label Nov 6, 2024
@lagartoverde lagartoverde merged commit f9ac88f into master Nov 7, 2024
3 checks passed
@lagartoverde lagartoverde deleted the feat/add-numbers-to-download-table branch November 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants