GN-4441 Remove template comments from anything requested #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove template from every editor document that is requested. This is the desired function: template comments are only needed when filling in a document and should be hidden when viewing a preview and signing/publishing a document.
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4441
frontend-gelinkt-notuleren PR #545
Setup
How to test/reproduce
Template comments should not be shown anywhere in GN, except when actually editing a document. Check if any places in GN still show them where they shouldn't.
Note: the frontend change will hide them via CSS. The service change removes them. Template comments should not exist anymore on documents that can't be edited anymore.
Challenges/uncertainties
The change was done in the editorDocument class instead of in the places where an editorDocument was created. This to avoid having to remember to add it when adding new functionality. In essence the template comment should never be part of anything in the prepublish service.
Not 100% certain if this is the best place though.