Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with predicate filtering to extract decisions #113

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

elpoelma
Copy link
Collaborator

@elpoelma elpoelma commented Jul 23, 2024

Overview

This PR includes a fix to the code responsible for extracting decisions of a document. It takes into account that the rdf type predicate can be represented by 'a' as well as 'http://www.w3.org/1999/02/22-rdf-syntax-ns#type'.

connected issues and PRs:

None

Setup

Test this PR in combination with https://github.com/lblod/app-gelinkt-notuleren.

prepublish:
    environment:
      NODE_ENV: "development"
    volumes:
      - <path-to-this-service>:/app/

How to test/reproduce

  • Start the application
  • Login and create a new meeting with a new agendapoint
  • Insert a decision in the agendapoint
  • Open up the meeting publishing page and select 'Decision List'
  • The decision list should correctly show up (the decisions should be found), no error should be shown.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Jul 23, 2024
@elpoelma elpoelma self-assigned this Jul 23, 2024
Copy link
Collaborator

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, maybe we should look for more places where we have this not expanded predicates because we fixed a ton of similar bugs recently

@elpoelma elpoelma merged commit 25398ee into master Jul 23, 2024
1 check passed
@elpoelma elpoelma deleted the fix/decision-extraction branch July 23, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants