Handle logical file uris with no related physical file information #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
force-pushed
the
fix/signing-fail
branch
from
8e1ccbc
to
8632d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how, but we have some
ext:VersionedNotulenin production, with aprov:generatedlogical file uri, but that logical file has no other triples linking to it, so there's therefore no way to find a physical file uri (if one exists), so no way to fetch the file. This handles this case by recreating a new file and storing it correctly.This flow is close to the previous flow, but since we've fixed the query, we're actually now requesting the file contents twice, once on
VersionedNotulen.query()and once onsignVersionedNotulen(). I started refactoring this out, but think this larger change should wait and we should push out this smaller fix to production asap.