-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown render #1179
Comments
@btzr-io do you know if this is the same issue as headings not showing up correctly (i.e. # Heading 1)? See lbry://filecontrols#d2d8e154e4db21c25dc9a9b0e75a3533a59b98f1
|
|
Thanks, totally missed that! |
@tzarebczan Tables, headings and almost anything that is converted into Probably to prevent: Markdown's XSS Vulnerability It's possible to enable specific tags (elements), |
@btzr-io @tzarebczan I'd say allow h3 and smaller and tables. Solution to XSS is orthogonal to this, as long as any elements are included that type of attack is possible. |
@btzr-io have you checked out https://github.com/mdx-js/mdx ? @seanyesmunt recently brought it up. |
@tzarebczan @seanyesmunt This looks more easy to integrate: https://github.com/mapbox/remark-react |
Fixed in #1441 |
The Issue
Markdown render is missing appropriate
css
styles, for blockquotes, links, code...Also some features like headings are disabled but still available in the editor.
Steps to reproduce
Expected behaviour
Display markdown correctly.
Actual behaviour
Description appears like plain text.
Notes
There are some issues with the markdown component, see: #1023 (comment)
The text was updated successfully, but these errors were encountered: