Fix for loss of data when pasting via context menu #1023
Conversation
|
Thanks @Jeremy1026 , sent you LBC on Discord for this! |
|
This doesn't fix the issue. I don't think it's an issue with the context. It actually looks like we don't even need this event listener for the context menu to work. I just deleted it and can still paste stuff. If I had to guess I think it's an issue with the publish component. |
| @@ -23,8 +23,10 @@ const { autoUpdater } = remote.require('electron-updater'); | |||
| autoUpdater.logger = remote.require("electron-log"); | |||
|
|
|||
| window.addEventListener('contextmenu', event => { | |||
There was a problem hiding this comment.
The check you added gets rid of the error that was showing up, but now it just never reaches the contextMenu() line. This entire piece can just be removed
There was a problem hiding this comment.
Correct. In this specific regard you are correct. I didn’t want to completely remove it, just in case it serves a purpose somewhere else within the application.
There was a problem hiding this comment.
You can remove it. It currently doesn't do anything. contextMenu isn't imported into that file, which is why the error is showing up. The actual context menu is handled in a different place
|
I've done a little more digging and it seems the issue is with Not really sure if there is a way around it or if we will need to make a PR to that project |
|
I'll give that a look-see. |
|
closing for now. please reopen if you're ready to work on it. |
No description provided.