Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent thumbnail sizes in 'Trending' section #721

Closed
wilsonk opened this issue Nov 9, 2017 · 6 comments
Closed

Inconsistent thumbnail sizes in 'Trending' section #721

wilsonk opened this issue Nov 9, 2017 · 6 comments
Assignees
Labels
type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@wilsonk
Copy link

wilsonk commented Nov 9, 2017

The Issue

One can game the trending section somewhat by using a very long channel name to make the size of the thumbnail bigger than others in that section.

Steps to reproduce

1.View trending section today (Nov 9, 2017)

Expected behaviour

All thumbnails should be the same size

Actual behaviour

Thumbnails with large channel names are larger than the rest

System Configuration

  • LBRY Daemon version: 0.17.1

  • LBRY App version:0.17.1

  • LBRY Installation ID: 26bru4Kjp3i3VM5KTFVV3ESEkDWEb9CCA2ate4L9XJYTr8PHUK4jPDQqz4JsG73Wfr

  • Operating system: Linux (Linux-4.4.0-97-generic-x86_64-with-Ubuntu-16.04-xenial)

Screenshots

screenshot_2017-11-09_11-45-19

@wilsonk
Copy link
Author

wilsonk commented Nov 9, 2017

Sorry, maybe that isn't the channel name being too long that is the problem, but the actual size of the file name. Perhaps that forces the 'red ship/free' icon to be pushed onto the next line which then makes the thumbnail longer not wider.

Easier to game the system this way, but with the ellipses eliding the file name size it might be easier to fix?

@wilsonk
Copy link
Author

wilsonk commented Nov 9, 2017

Hmm, maybe I will eventually get this right! It actually looks like a combination of both the long file name and channel name may be the problem...??

@tzarebczan tzarebczan added the priority: blocker Issue is blocking release, do ASAP label Nov 9, 2017
@kauffj kauffj removed the priority: blocker Issue is blocking release, do ASAP label Nov 9, 2017
@neb-b
Copy link

neb-b commented Nov 10, 2017

I think we should remove the card design. It can be tough to deal with when trying to keep boxes the same height.

If we remove the card we could increase the visible text limit and not have to worry about different container heights. I think something like this redesign http://lab.zzk.fr/lbry/ would look really nice.

@liamcardenas thoughts?

@oakey22
Copy link

oakey22 commented Nov 10, 2017

@seanyesmunt i absolutely love that design, so professional looking

@liamcardenas liamcardenas added the type: improvement Existing (or partially existing) functionality needs to be changed label Nov 13, 2017
@akinwale
Copy link
Contributor

Created a PR to fix this since it kept bothering me.

Also, @seanyesmunt that new design is amazing! You should show the entire team.

kauffj pushed a commit that referenced this issue Nov 15, 2017
Issue #721 fix - Inconsistent thumbnail sizes
@liamcardenas
Copy link
Contributor

@tzarebczan can you verify this is working?

Ruk33 pushed a commit that referenced this issue Feb 25, 2022
In 36fe736, the approach to fix the "missing chunk" error and user using old code was to disable caching on the html so that user always grabs the one that's pointing to the latest ui.js.

But https://cristian.sulea.net/blog/disable-browser-caching-with-meta-html-tags/ says 3 sets of `meta` is needed to, and we missed out one. That probably explains why refreshing sometimes does not work, although I've also read that some browsers simply ignores these meta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

7 participants