Issue #721 fix - Inconsistent thumbnail sizes #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
reviewed
Nov 15, 2017
| @@ -1,4 +1,12 @@ | |||
|
|
|||
| .channel-name { | |||
| width: calc(var(--card-small-width) * 2 / 3); | |||
There was a problem hiding this comment.
Is this needed? I think it should be fine with just the nowrap and ellipsis. If it's extending to the edge, we should add a padding to the card.
There was a problem hiding this comment.
Without specifying the width, long text will push the price indicator to the next line. I suppose we could simplify this using a percentage width instead of the calculation. 60% or 70% should be fine.
There was a problem hiding this comment.
Gotcha. This should be fine for now, we will be moving to the new design sometime soon.
There was a problem hiding this comment.
(Proper solution is probably a flex layout rather than calc, but not demanding propriety. Especially since we're likely to redesign soon anyway.)
neb-b
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for long channel names resulting in the inconsistent thumbnail sizes.