Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content address extends outside of visible area in card #741

Closed
neb-b opened this issue Nov 14, 2017 · 2 comments
Closed

content address extends outside of visible area in card #741

neb-b opened this issue Nov 14, 2017 · 2 comments
Labels
help wanted level: 1 No knowledge of the existing code required type: bug Existing functionality is wrong or broken

Comments

@neb-b
Copy link

neb-b commented Nov 14, 2017 •
edited
Loading

The Issue

When going to an address that is very long, content may extend passed the edge of the card

Steps to reproduce

  1. Navigate to lbry://@seanyesmunt#2fa8ecba445648eae50cb6e98948e67a417c9017/thisisaverylongstringthatiscutoff
  2. Notice content extending off the page
  3. Publish new content
  4. Go to the new content page before the publish is done, see it extend off the page

Expected behaviour

I should be able to see the entire address
Long addresses should probably wrap, maybe there is a better way, does it need to be in a card?
Since the address is in the search bar, do we need the address here?

Actual behaviour

The address is cut off

Screenshots

screen shot 2017-11-14 at 9 00 37 am

screen shot 2017-11-14 at 9 01 56 am
@neb-b neb-b added the type: bug Existing functionality is wrong or broken label Nov 14, 2017
@liamcardenas liamcardenas added level: 1 No knowledge of the existing code required level: 2 Some knowledge of the existing code is recommended help wanted and removed level: 2 Some knowledge of the existing code is recommended labels Dec 14, 2017
amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 10, 2018
@amitnndn
lbryio#741 Fixing content address extending outside of visible area i…
aa493f9 
…n card
@amitnndn
Copy link
Contributor

Since this is a small fix, I am fixing this as a part of #1569 PR.

@amitnndn amitnndn mentioned this issue Jun 10, 2018
Merged
@tzarebczan
Copy link
Contributor

Closing per #1569

Ruk33 pushed a commit that referenced this issue Feb 25, 2022
@infinite-persistence
Update remaining chat link (#741)
801d24a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted level: 1 No knowledge of the existing code required type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amitnndn @liamcardenas @tzarebczan @neb-b