Adding ability to view logs and open log directory #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amitnndn thanks for the contribution! We'll get this reviewed shortly. Similar to last time, please see https://lbry.io/faq/tips if you'd like a tip for your contribution :) |
|
Thanks, @tzarebczan! I fixed another very simple bug in the app and included that as a part of this PR. Did not want to go through the trouble of creating another PR for such a simple fix. Let me know if that is alright! |
neb-b
approved these changes
Jun 11, 2018
| @@ -20,5 +20,6 @@ module.name_mapper='^lbry\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/lbry\1' | |||
| module.name_mapper='^rewards\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/rewards\1' | |||
| module.name_mapper='^modal\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/modal\1' | |||
| module.name_mapper='^app\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/app\1' | |||
| module.name_mapper='^native\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/native\1' | |||
There was a problem hiding this comment.
@seanyesmunt This was to resolve a flow error that was on in line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1556 - Adding ability to open logs and view log directory on the help page.
#741 - Fixing content address extending outside of the visible area in the card. (I am including this fix as a part of this PR since it is a small relatively small fix - 3 lines)
Changes
h1element so that long URLs do not extend outside the visible area.Preview
#1556
#741
P.S: I have tested this only on macOS Sierra and theoretically should work on other operating systems as well. Let me know if it doesn't!