Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel page claim caching / other optimizations #1255

Closed
tzarebczan opened this issue Apr 2, 2018 · 2 comments
Closed

Channel page claim caching / other optimizations #1255

tzarebczan opened this issue Apr 2, 2018 · 2 comments
Assignees
Labels
area: ux area: viewer level: 3 Significant knowledge of the existing code is recommended Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Apr 2, 2018

The Issue

When you go into a channel page likelbry://@lumbridgecity, the page starts fetching content which takes a bit of time. If you enter a claim or go to another page, and then go back, it re-fetches content again making this a slow process. We should try to add some type of caching to reduce the subsequent load times. Have to take into account new/updated claims as well.

Update: The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it.

Expected Behaviour

Faster subsequent load times

Actual Behaviour

Reload every page as if it were the first time seeing it

Suggested Solutions

Employ caching strategy

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed area: ux level: 3 Significant knowledge of the existing code is recommended area: viewer labels Apr 2, 2018
@tzarebczan tzarebczan changed the title Channel page claim caching Channel page claim caching / other optimizations May 31, 2018
@alyssaoc alyssaoc added this to the July 23rd (desktop) milestone Jul 9, 2018
@neb-b neb-b closed this as completed Jul 11, 2018
@tzarebczan
Copy link
Contributor Author

Reopening to address the last issue (cc: @daovist )
The current process also runs claim_list_by_channel on the first page which returns all the claim data. It then proceeds to run a resolve on each of the claims (if they have not been visited in the current session). The resolve should not be needed as the prior call has all claim data returned. If we do need to run a resolve, we should batch it.

@tzarebczan
Copy link
Contributor Author

Closed by lbryio/lbry-redux#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux area: viewer level: 3 Significant knowledge of the existing code is recommended Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

4 participants