Channel page caching #1750
Merged
Channel page caching #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
suggested changes
Jul 11, 2018
src/renderer/page/channel/view.jsx
Outdated
| <span className="empty">{__('No content found.')}</span> | ||
| ) : ( | ||
| null | ||
| ); |
There was a problem hiding this comment.
maybe
...
) : !fetching && <span className="empty">{__('No content found.')}</span>;
To avoid the nested ternarys
src/renderer/page/channel/view.jsx
Outdated
| <h1>{name}</h1> | ||
| <h1> | ||
| {name} | ||
| {fetching ? <BusyIndicator /> : null} |
|
This is great. So much smoother. |
|
I also cleaned up types in |
neb-b
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1255
Moves
<BusyIndicator>to title bar.Refactors
contentListto show "No content found" only after fetch is complete;nullwhile fetching.There is still some chance that a user will click the wrong tile but the update is very fast and pretty smooth. The best way I see to prevent this is to disable navigation for ~1sec following the update. This could be done by adding a throttle property to the state along with corresponding actions, reducers, and a thunk in doNavigate, or migrating from thunks to middleware, both of which seem well beyond the scope of this issue.