Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel hyperlink fires twice, going back requires two clicks #1794

Closed
tzarebczan opened this issue Jul 20, 2018 · 1 comment
Closed

Channel hyperlink fires twice, going back requires two clicks #1794

tzarebczan opened this issue Jul 20, 2018 · 1 comment
Labels
type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

The Issue

If you go into a channel, it takes 2 clicks of the back button to get back to the previous page. @seanyesmunt confirmed the history navigate action is being called twice.

Could be related to the latest channel caching enhancements.

Steps to Reproduce

  1. Click into a channel, click back
  2. Takes 2 clicks to go back

Expected Behaviour

Tell us what should happen.

Actual Behaviour

Tell us what happens instead.

Suggested Solutions

Tell us your suggested solutions if you have any.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots
@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Jul 20, 2018
@tzarebczan
Copy link
Contributor Author

Fixed in #1797

jessopb pushed a commit that referenced this issue Jul 15, 2022
@infinite-persistence
Bump weekly-watch auto claim interval (#1794)
02d017d 
## Ticket
1768 Check reward claiming logic

## Change
- Bump to >6.5 days
- Remove unnecessary `Math.ceil` -- not sure why I added that. It was causing diff to hit earlier than necessary.

> _and I'm 5 days away._

Not sure how to replicate/explain this, though -- the old code would have still covered this range.  One possibility is when `last_claimed` is not defined, where we assume user hasn't claimed yet. We could flip this to assume "claimed" and just let the user manually claim as the fallback -- let me know.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzarebczan @lbry-bot