Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enter Reward Code" doesn't accept Enter Key to trigger Redeem #2152

Closed
june128 opened this issue Dec 24, 2018 · 7 comments
Closed

"Enter Reward Code" doesn't accept Enter Key to trigger Redeem #2152

june128 opened this issue Dec 24, 2018 · 7 comments
Assignees
Labels
good first issue help wanted type: bug Existing functionality is wrong or broken

Comments

@june128
Copy link

june128 commented Dec 24, 2018

The Issue

Steps to Reproduce

  1. Go to LBRY -> Wallet -> Rewards -> Custom Code -> Enter Code
  2. Enter a code
  3. Press the enter key

Expected Behaviour

This should do the same as clicking the "Redeem"-Button.

Actual Behaviour

Nothing happens.

Suggested Solutions

System Configuration

  • LBRY Daemon version: 0.30.1
  • LBRY App version: 0.26.1
  • LBRY Installation ID: 9VS5gCQN19VnWvMapaPXd7v4oN7fRTZgExbKeKztv1q57hwC2bWZYKiywh6V4s5PkN
  • Operating system: Mac OS 18.2.0

Anything Else

Screenshots

This is the UI element this issue is about:
screenshot 2018-12-24 at 03 48 10_lbry_enter_reward_code

@neb-b
Copy link

neb-b commented Dec 24, 2018

Thanks for the issue @julianschacher !

This is an issue with all modals (I think the only other one is with email verification)

I think the issue is that the button type="submit" is not inside of these form elements.

@neb-b neb-b added type: bug Existing functionality is wrong or broken help wanted good first issue labels Dec 24, 2018
@tzarebczan
Copy link
Contributor

@julianschacher, thanks for opening this issue - great suggestion! Can we send you LBC in appreciation for filling this out?

@tzarebczan tzarebczan self-assigned this Jan 21, 2019
@neb-b
Copy link

neb-b commented Feb 12, 2019

Will be fixed in #2279

@june128
Copy link
Author

june128 commented Feb 16, 2019

@seanyesmunt Awesome, thank you for your work!
@tzarebczan Thanks for the offer, but I don't think I deserve LBC for opening issue, which isn't a critical bug or something very special.

@neb-b neb-b closed this as completed Feb 16, 2019
@neb-b
Copy link

neb-b commented Feb 16, 2019

@julianschacher Everything helps! It was helpful to have this issue created. It allowed us to track and prioritize it. Not sure when we would have fixed this if didn't create the issue!

@june128
Copy link
Author

june128 commented Feb 16, 2019

@seanyesmunt I agree, creating issues is super useful.
But for me (as a developer?) it's something natural to do, just because I want the project/product I use to improve. And if everyone lives with this mindset, you get payed by others reporting issues in projects you work on yourself.
I appreciate the gesture tho and I think it motivates people in general to report issues they find.

@neb-b
Copy link

neb-b commented Feb 16, 2019

I understand where you are coming from. Hope to see you around 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

3 participants