Use shared components repo for button/form/table styling #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2019
neb-b
force-pushed
the
components
branch
2 times, most recently
from
9c43ac7
to
a16913b
Compare
neb-b
changed the title
|
|
skhameneh
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
data-theme=>data-mode.btn=>.buttonFormRowIt's mostly just markup changes. I still plan to make more changes/cleanup in my next PR. I just wanted to get it working, then see how much more we can strip out after this.
Dark mode still needs some work, but I think most of these changes will go in the components repo.