Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Bookmarking / Watch later lists #622

Closed
10 tasks
tzarebczan opened this issue Sep 26, 2017 · 12 comments
Closed
10 tasks

Feature Request: Bookmarking / Watch later lists #622

tzarebczan opened this issue Sep 26, 2017 · 12 comments
Labels
help wanted level: 4 Intimate knowledge of the existing code is recommended needs: tech design Needs technical design signoff before implementation can begin priority: medium Work needs to be done within 2-3 sprints type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Sep 26, 2017

Edit by Liam: Note to contributors -- feel free to tackle this! But keep in mind that this needs to be implemented well and integrated well into our design and current redesign efforts. If you want to work on this, I recommend talking to either me or @seanyesmunt.

The Issue

I've seen this feature requested or talked about a couple times (I think someone was even working on a proof of concept) so I wanted to track it via an issue here.

The bookmarking feature would allow the user to maintain one or more lists to which users can save claims/channels to. Claim and channel pages would require an "Add to Bookmarks" button with a dropdown the ability to create a new list or add to existing one.

This will most likely need an associated lbry/lbryschema ticket to store bookmarks in a db.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
@tzarebczan tzarebczan added contributor friendly type: improvement Existing (or partially existing) functionality needs to be changed labels Sep 26, 2017
@btzr-io
Copy link
Collaborator

btzr-io commented Sep 26, 2017

Yep, that was me: bryio/lbry-app/tree/btzr/new
( Only a proof of concept not ready for a PR )
I'm working on other stuff, so I'll try next week 😛

@kauffj
Copy link
Member

kauffj commented Sep 26, 2017

@btzr-io can we discuss that feature a bit before you do much more work on it?

@btzr-io
Copy link
Collaborator

btzr-io commented Nov 12, 2017

Claim and channel pages would require an "Add to Bookmarks"

I think channels should be handle on Subscriptions #715

@btzr-io
Copy link
Collaborator

btzr-io commented Nov 12, 2017

Todo

  • Allow the user to maintain one or more lists to which users can save claims.
  • Add to Bookmarks button with a dropdown the ability to create a new list or add to existing one.
  • Default List: favorites
  • Export / import bookmarks list [ ? ]

@liamcardenas liamcardenas added help wanted level: 4 Intimate knowledge of the existing code is recommended and removed contributor friendly labels Dec 15, 2017
@tzarebczan
Copy link
Contributor Author

Related: #1676

@alyssaoc alyssaoc added priority: medium Work needs to be done within 2-3 sprints App "C: labels Aug 28, 2018
@alyssaoc alyssaoc added needs: tech design Needs technical design signoff before implementation can begin Epic labels Sep 21, 2018
@alyssaoc alyssaoc removed the Epic label Oct 1, 2018
@jeff-hykin
Copy link

This is a killer feature for switching from YouTube, at least for me. I use it to que additional videos while a video is playing.

If time permits me to learn the codebase, I have the background for helping with a PR. Guidance/status update on this issue would be helpful.

I just found lbry today. The fact that I can find this issue for a feature (instead of submitting feedback to who-knows-where) is fantastic. The Agile workflow is also great to see.

@neb-b
Copy link

neb-b commented May 26, 2020

Hey @jeff-hykin !

This feature is on hold until we have a plan for playlists
#1982

Once we have a way to build proper playlists, then it will be simple to create a new "watch later" playlist.

@kauffj
Copy link
Member

kauffj commented May 26, 2020

If @jeff-hykin wants to work on this, IMO there'd be no problem with storing watch later in your local settings (ideally wallet) to start. While we do need to build out playlists generally, proper playlists will require spending LBC (even if a small amount), since it is a publish.

I'm not sure watch later should work that way. So if a first version was just a button/element that pushed to local wallet state (this way it propagates) and that added the corresponding list to a tab in your Library, I think that could make sense...

@jeff-hykin
Copy link

@seanyesmunt that's great to hear! Thanks for the update.

@jeff-hykin
Copy link

jeff-hykin commented May 28, 2020

@kauffj LocalStorage on the web would be a breeze to implement on my side. I'm not sure how that would work with your mobile software stack, and I'll have to get more familiar with the wallet.

It's just a "play next" buffer that would take priority over the existing autoplay, so temporary storage would work fine. I only use the YouTube "watch later" playlist as a makeshift solution, and it works well enough. The most common situation is when two or more of the related videos seem interesting, but I don't want to have to manually perform a backtracking depth-first search process to eventually reach the second video.

If playlists were already implemented it would make sense to reuse that logic, especially for removing and changing the order of videos in the que. It could deserve it's own issue/feature request, but for now I think the logic is interwoven enough to be apart of the same discussion.

@neb-b
Copy link

neb-b commented May 28, 2020

@jeff-hykin we already have a (semi-broken atm) system in place to sync data between devices. All you need to do is add it to the redux store, then add that key in a few other places.

Maybe you could start by creating a watchLater reducer? It would just need to store a list of lbry URLs, and would need actions to add to the end of the list, and remove from the front of the list.

@apenasrr
Copy link

apenasrr commented Jun 6, 2020

sync with low-coupling
A small and improvised suggestion on one of the ways to enable synchronization of these 'Bookmarking / Watch later lists' between different devices (desktop, mobile), would be to offer the user the possibility of defining a folder on their device to 'dump' the data they support this 'bookmarking / watch later lists' function.
Thus, the user is responsible for informing a folder that is being monitored by a synchronization service, such as the dropbox.
This type of 'freedom' and 'low-coupling' of synchronizing settings in apps, has already been implemented, for example, in the settings of the notepad ++ text editor.

that serves merely as another possibility at the table :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted level: 4 Intimate knowledge of the existing code is recommended needs: tech design Needs technical design signoff before implementation can begin priority: medium Work needs to be done within 2-3 sprints type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

8 participants