-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Bookmarking / Watch later lists #622
Comments
Yep, that was me: bryio/lbry-app/tree/btzr/new |
@btzr-io can we discuss that feature a bit before you do much more work on it? |
I think channels should be handle on |
Todo
|
Related: #1676 |
This is a killer feature for switching from YouTube, at least for me. I use it to que additional videos while a video is playing. If time permits me to learn the codebase, I have the background for helping with a PR. Guidance/status update on this issue would be helpful. I just found lbry today. The fact that I can find this issue for a feature (instead of submitting feedback to who-knows-where) is fantastic. The Agile workflow is also great to see. |
Hey @jeff-hykin ! This feature is on hold until we have a plan for playlists Once we have a way to build proper playlists, then it will be simple to create a new "watch later" playlist. |
If @jeff-hykin wants to work on this, IMO there'd be no problem with storing watch later in your local settings (ideally wallet) to start. While we do need to build out playlists generally, proper playlists will require spending LBC (even if a small amount), since it is a publish. I'm not sure watch later should work that way. So if a first version was just a button/element that pushed to local wallet state (this way it propagates) and that added the corresponding list to a tab in your Library, I think that could make sense... |
@seanyesmunt that's great to hear! Thanks for the update. |
@kauffj LocalStorage on the web would be a breeze to implement on my side. I'm not sure how that would work with your mobile software stack, and I'll have to get more familiar with the wallet. It's just a "play next" buffer that would take priority over the existing autoplay, so temporary storage would work fine. I only use the YouTube "watch later" playlist as a makeshift solution, and it works well enough. The most common situation is when two or more of the related videos seem interesting, but I don't want to have to manually perform a backtracking depth-first search process to eventually reach the second video. If playlists were already implemented it would make sense to reuse that logic, especially for removing and changing the order of videos in the que. It could deserve it's own issue/feature request, but for now I think the logic is interwoven enough to be apart of the same discussion. |
@jeff-hykin we already have a (semi-broken atm) system in place to sync data between devices. All you need to do is add it to the redux store, then add that key in a few other places. Maybe you could start by creating a |
sync with low-coupling that serves merely as another possibility at the table :) |
Edit by Liam: Note to contributors -- feel free to tackle this! But keep in mind that this needs to be implemented well and integrated well into our design and current redesign efforts. If you want to work on this, I recommend talking to either me or @seanyesmunt.
The Issue
I've seen this feature requested or talked about a couple times (I think someone was even working on a proof of concept) so I wanted to track it via an issue here.
The bookmarking feature would allow the user to maintain one or more lists to which users can save claims/channels to. Claim and channel pages would require an "Add to Bookmarks" button with a dropdown the ability to create a new list or add to existing one.
This will most likely need an associated lbry/lbryschema ticket to store bookmarks in a db.
System Configuration
Anything Else
Screenshots
Acceptance Criteria
Definition of Done
The text was updated successfully, but these errors were encountered: