Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Subscriptions - Button and Page Resolution #715

Closed
ghost opened this issue Nov 6, 2017 · 3 comments
Closed

FEATURE: Subscriptions - Button and Page Resolution #715

ghost opened this issue Nov 6, 2017 · 3 comments
Assignees
Labels
type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@ghost
Copy link

ghost commented Nov 6, 2017

Ideal Release Date: 12/11, morning EST.

The Issue

(1) User needs to Subscribe to channel ("subscribe")
(2)* User needs to see their Subscriptions ("subscribe_list")
(3) Publisher needs to see their subscriber count ("subscriber_count")
(4)** Publisher needs to see where their subscriber count arrived from ("subscriber_sourceCount")

*This is a second Homepage, structurally identical to current Homepage, populated by local "subscribe_list" content.
**This is an analytic. Enable a Publisher to see which pages generated what Subscribe clicks.

Expected behaviour IN ORDER OF PRIORITY

Subscribe Button on Video Page
Subscribe Button on Channel Page
Subscription Homepage View
Publisher-side Channel Data related to Subscribe commands

@ghost ghost assigned lyoshenka and ghost Nov 6, 2017
@neb-b neb-b added the type: improvement Existing (or partially existing) functionality needs to be changed label Nov 13, 2017
@liamcardenas
Copy link
Contributor

We need to figure out how subscriptions will integrate with the daemon.

@ghost
Copy link
Author

ghost commented Nov 13, 2017

FWIW, I strongly believe Subscriptions belong at the app layer. This is not a fundamental aspect of LBRY, it is aesthetic and application-specific.

@kauffj
Copy link
Member

kauffj commented Nov 14, 2017

If subscriptions are only at the app/local level (which I think is reasonable), it will be tricky to count the number of subscribers.

@ghost ghost assigned liamcardenas and neb-b and unassigned lyoshenka Nov 28, 2017
@ghost ghost added this to the December 8 milestone Nov 28, 2017
@neb-b neb-b unassigned liamcardenas and ghost Dec 4, 2017
@neb-b neb-b closed this as completed Dec 8, 2017
Ruk33 pushed a commit that referenced this issue Feb 25, 2022
* Rewrite __ to be usable on server side

* Add changelog entry

* Clean invisible characters from primaryModValue

* Revert "Rewrite __ to be usable on server side"

This reverts commit 53f63c0.

* Make pass-through placeholder for __ fn until it can be adapted for node.

* Switch messagages to inline interpolation until i18n done

Co-authored-by: Thomas Zarebczan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

4 participants