Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keyboard shortcut to quit the app on Windows #1202

Merged
merged 11 commits into from
Mar 30, 2018
Merged

feat: add keyboard shortcut to quit the app on Windows #1202

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
be559be
alternative quit APP by click CTRL+Q
ykris45 Mar 28, 2018
5205bb5
Update CHANGELOG.md
ykris45 Mar 28, 2018
f2af163
Update setupBarMenu.js
ykris45 Mar 28, 2018
97d47e0
fix formating 1
ykris45 Mar 28, 2018
e70d8f2
Update CHANGELOG.md
ykris45 Mar 28, 2018
6db06a0
update review changes
ykris45 Mar 30, 2018
b50606b
delete unused var
ykris45 Mar 30, 2018
572d68d
Update CHANGELOG.md
ykris45 Mar 30, 2018
4b52795
Update CHANGELOG.md
ykris45 Mar 30, 2018
0a4f781
added file menu item
ykris45 Mar 30, 2018
97fbef8
Update CHANGELOG.md
ykris45 Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* LBRY URLs not working on Linux ([#1120](https://github.com/lbryio/lbry-app/issues/1120))
* Fix Windows notifications not showing ([#1145](https://github.com/lbryio/lbry-app/pull/1145))
* Fix export issues ([#1163](https://github.com/lbryio/lbry-app/pull/1163))

* Fix Keyboard Shortcut to Quit APP ([#1163](https://github.com/lbryio/lbry-app/pull/1202))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this as "Add keyboard shortcut to quit the app on Windows" under an unreleased section and not under "Fix".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IGassmann i cannot see where a unreleased section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@IGassmann like this guys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

572d68d done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs to be under an Added subsection. Also, notice that the pull request number doesn't match the link number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.



## [0.20.0] - 2018-01-30
Expand Down
5 changes: 5 additions & 0 deletions src/main/menu/setupBarMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ export default () => {
}
},
},
{
label: 'Close',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the label "Close" as it should be automatically specified by the role.

accelerator: 'CmdOrCtrl+Q',
role: 'quit',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be under the help menu. Add it to a new submenu "File".

{
label: 'Frequently Asked Questions',
click: () => {
Expand Down