Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show exact wallet balance on mouse hover over #1305

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Show exact wallet balance on mouse hover over #1305

merged 2 commits into from
Apr 17, 2018

Conversation

miikkatu
Copy link
Contributor

@miikkatu miikkatu commented Apr 9, 2018

This implements #1259.

@neb-b neb-b self-requested a review April 16, 2018 18:43
@lbry-bot lbry-bot assigned neb-b and unassigned liamcardenas Apr 16, 2018
neb-b
neb-b suggested changes Apr 16, 2018
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like this messed up the the balance color. The balance should always be green, and the "You have" should turn green on hover

@lbry-bot lbry-bot assigned liamcardenas and unassigned neb-b Apr 16, 2018
@miikkatu
Copy link
Contributor Author

Balance color issue is now fixed!

@lbryio lbryio deleted a comment Apr 17, 2018
@neb-b
Copy link

neb-b commented Apr 17, 2018

Sweet! Just add a changelog to this too and I will merge

@miikkatu
Copy link
Contributor Author

Changelog updated.

@lbryio lbryio deleted a comment Apr 17, 2018
@neb-b neb-b merged commit f21061e into lbryio:master Apr 17, 2018
@miikkatu miikkatu deleted the show-exact-balance-on-hover branch April 17, 2018 06:14
@miikkatu miikkatu restored the show-exact-balance-on-hover branch April 17, 2018 06:14
@tzarebczan
Copy link
Contributor

Thanks @miikkatu! Have your contribution email, will follow up soon!

@tzarebczan tzarebczan mentioned this pull request Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b approved these changes

Assignees

@liamcardenas liamcardenas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miikkatu @neb-b @tzarebczan @liamcardenas