Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full content-type #1333

Merged
merged 3 commits into from
Apr 25, 2018
Merged

Show full content-type #1333

merged 3 commits into from
Apr 25, 2018

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented Apr 17, 2018 •
edited
Loading

Issue

For some file types, the "Content-Type" description is not shown correctly. I've noticed that for .odt (open office files) and .stl (3d printing files) the description is "application". It could be confusing for users and discourage downloads.

See: lbryio/lbry-sdk#1028

Changes

@btzr-io btzr-io mentioned this pull request Apr 17, 2018
Closed
2 tasks
@btzr-io
Copy link
Collaborator Author

btzr-io commented Apr 19, 2018

Fix conflicts c2a010c

@tzarebczan tzarebczan requested a review from neb-b April 23, 2018 12:48
@lbry-bot lbry-bot assigned neb-b and unassigned liamcardenas Apr 23, 2018
@tzarebczan
Copy link
Contributor

@seanyesmunt should we discuss this or can it be merged?

@neb-b neb-b merged commit 5cc62a6 into master Apr 25, 2018
@btzr-io btzr-io deleted the full-content-type branch April 25, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b Awaiting requested review from neb-b

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btzr-io @tzarebczan @liamcardenas @neb-b