Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add togglable QR code to wallet address component #1582

Merged
merged 2 commits into from
Jun 14, 2018
Merged

add togglable QR code to wallet address component #1582

merged 2 commits into from
Jun 14, 2018

Conversation

daovist
Copy link
Contributor

@daovist daovist commented Jun 12, 2018

No description provided.

@tzarebczan
Copy link
Contributor

I'm not crazy about how the button looks on both light and dark themes. Maybe @seanyesmunt can work on styling it better.

Also, doesn't work in dark mode - looks like some of the background is seeping through and adding some extra tiny lines to the QR.
qr code

@neb-b
Copy link

neb-b commented Jun 12, 2018 •
edited
Loading

I agree @tzarebczan. There was some styling to ensure the qr code had a white border so that it worked with dark mode. Maybe we lost that? This should probably use the button="link" style.

@daovist
Copy link
Contributor Author

daovist commented Jun 12, 2018

updated to button="link"

@neb-b neb-b self-requested a review June 13, 2018 16:35
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Jun 13, 2018
neb-b
neb-b suggested changes Jun 13, 2018
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-06-13 at 12 33 31 pm

Seeing this with the error

Failed prop type: Invalid prop `size` of type `string` supplied to `QRCodeCanvas`, expected `number`.
in QRCodeCanvas (created by QRCode)

Not sure why it's overlapping. I also think we can make this a little bit smaller.

@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Jun 13, 2018
@tzarebczan
Copy link
Contributor

Working on dark mode now!

@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Jun 14, 2018
@neb-b neb-b merged commit f84242b into master Jun 14, 2018
@neb-b neb-b deleted the qr-code branch September 10, 2018 19:26
jessopb pushed a commit that referenced this pull request Jul 15, 2022
@mayeaux
Styling touchups for image previews (#1582)
dcf9b18 
* styling touchups for image previews

* update vtt-thumbnails commit hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b approved these changes

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daovist @tzarebczan @neb-b