Publish fixes #1716
Publish fixes #1716
Conversation
|
Tested and working as expected for me. When I edit the name, I get the warning about selecting a file. Publish works after going down that route. Also able to change the name back and edit as expected. |
| {!bid && <div>{__('A bid amount is required')}</div>} | ||
| {!tosAccepted && <div>{__('You must agree to the terms of service')}</div>} | ||
| </div> | ||
| !isFormValid && ( |
There was a problem hiding this comment.
This is fine, but it's worth considering in the future how at least some of these could be funneled directly to the fields rather than all shown in a global area.
There was a problem hiding this comment.
They are shown in the field, this is just extra help at the bottom of the page so it isn't confusing why the publish button is greyed out.
There was a problem hiding this comment.
(On second thought, this still feels somewhat wrong. Maybe the superior pattern is one that provides a link to scroll to the fields with errors? But obviously non-blocking)
| @@ -99,6 +99,15 @@ table.table--transactions { | |||
| } | |||
| td:nth-of-type(3) { | |||
| width: 22.5%; | |||
|
|
|||
| .btn--link { | |||
There was a problem hiding this comment.
I like this tourniquitting CSS but I dislike how it is being applied. Is tourniqueting text really just a property of button links when they're inside the 3rd td element of a <table.table--help>? This seems unlikely.
If we're struggling to find a clear global rule for these, I think it makes more sense to apply turniquitting as either a table or cell level class property.
Fixes
Disabled the file input when
publishing === trueFix an issue with form error styling at the bottom of the publish form
#1714
#1647
Moved button styling to be specific to the transactions table because it was affecting buttons it shouldn't.