Handle LBC unavailable error from ShapeShift without breaking the app #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
changed the title
kauffj
approved these changes
Jul 9, 2018
| @@ -1,3 +1,5 @@ | |||
| export const NO_DEPOSITS = 'no_deposits'; | |||
| export const RECEIVED = 'received'; | |||
| export const COMPLETE = 'complete'; | |||
| export const AVAILABLE = 'available'; | |||
| export const UNAVAILABLE = 'unavailable'; | |||
| @@ -65,9 +66,16 @@ export const shapeShiftInit = () => (dispatch: Dispatch): ThunkAction => { | |||
| return shapeShift | |||
| .coinsAsync() | |||
| .then(coinData => { | |||
| if (coinData.LBC.status === SHAPESHIFT_STATUSES.UNAVAILABLE) { | |||
| dispatch({ | |||
jessopb
pushed a commit
that referenced
this pull request
Jul 15, 2022
* Remove ad-handling in videojs.jsx Primary impetus is to remove unnecessary IntersectionObserver usage, but it should be removed anyway because: - no longer relevant today with Adnimation's script. - we also globally hide floating ads now, so no more invisible divs. - the code is wrongly placed -- it's not the responsibility of the Videojs component. * use-lazy-loaded: skip if IntersectionObserver is not supported ## Issue Page not loading in older Safari (e.g. ipad air 2) ## Approach Instead of using a polyfill (which comes with implementation caveats), just not apply the lazy-loading for those old browsers. Not lazy-loading is better than not loading at all, plus this is way easier to test (even by just reading the code) than testing out the polyfill implementation's caveats. The cons is we would need the polyfill if we use it in other places in the future. ## Code Changes Factor out the src-setting code, and use it directly when IntersectionObserver is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LBC is unavailable on shapeshift (like it is right now) the app breaks on the Get Credits page. We need to explicitly check that it is available before worrying about other coins availability.
If it's unavailable, stop and show an error message.