hide community row if nsfw content is hidden #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
commented
Jul 12, 2018
| @@ -21,7 +21,6 @@ | |||
| } | |||
|
|
|||
| .card--small { | |||
| width: var(--card-small-width); | |||
neb-b
commented
Jul 12, 2018
| @@ -283,6 +282,12 @@ | |||
| &:last-of-type { | |||
| padding-bottom: $spacing-vertical * 2/3; | |||
| } | |||
|
|
|||
| // For the message if community top bids are disabled | |||
| .card__content.help { | |||
There was a problem hiding this comment.
This is needed because of the special CSS that happens inside the CategoryList component, that allows content to scroll "off" the side of the edge. That behavior doesn't exist anywhere else in the app.
skhameneh
approved these changes
Jul 12, 2018
| @@ -1,11 +1,11 @@ | |||
| // @flow | |||
| import React from 'react'; | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
It's needed after adding React.Fragment. Flow acts funny without it.
|
This looks good to me and confirmed with Rob that will move trending to top (or 2nd from top) so that Community top bids will be at the bottom. This means we won't have to worry about the weird spacing. |
jessopb
pushed a commit
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should keep the "row" styling somewhat there. Then users know this would be a scrollable row just like the other rows, if they change their settings.