-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic wallet encryption flows #1785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very minor styling issue and a question.
onChange={event => this.onChangePassword(event)} | ||
/> | ||
</FormRow> | ||
<FormRow padded> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using FormRow
, use <div className="card__actions"><Button />...
onChange={event => this.onChangeUnderstandConfirm(event)} | ||
/> | ||
</FormRow> | ||
<FormRow padded> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, use className="card__actions"
{__( | ||
'Your wallet has been encrypted with a local password, performing this action will remove this password.' | ||
)} | ||
<FormRow padded> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be a FormRow
}; | ||
} | ||
|
||
updateStatus() { | ||
Lbry.status().then(status => { | ||
this._updateStatusCallback(status); | ||
window.status = status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
See /issues/1097
and lbryio/lbry-redux/pull/59