Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get recommended videos from search based on title #1845

Merged
merged 7 commits into from
Aug 13, 2018
Merged

get recommended videos from search based on title #1845

merged 7 commits into from
Aug 13, 2018

Conversation

neb-b
Copy link

@neb-b neb-b commented Aug 2, 2018

screen shot 2018-08-07 at 1 13 57 am

@neb-b neb-b force-pushed the next-video branch 2 times, most recently from a71f320 to a411a62 Compare August 3, 2018 18:28
@tzarebczan
Copy link
Contributor

3 things I noticed:

  1. the URL is missing from the search bar when you go into it the first time. It comes back the next time you re-enter.
  2. if you go into lbry://three - you get a suggestion for lbry://three#claimid (that matches the same claim id). Probably a vanity url issue .
  3. I noticed the play button black > green (takes about a second or two) - can we speed this up? Why does it happen at all?

@neb-b
Copy link
Author

neb-b commented Aug 7, 2018

@tzarebczan
issue 1 will be fixed with lbryio/lbry-redux#65
Still thinking about how I can fix issue 2
issue 3 seems to exist on previous versions. Nothing from this PR should mess with that (it is definitely a valid issue though)

@neb-b neb-b force-pushed the next-video branch 2 times, most recently from 1d11cac to e9cc647 Compare August 9, 2018 16:41
@neb-b neb-b requested a review from skhameneh August 9, 2018 16:41
@lbry-bot lbry-bot assigned skhameneh and unassigned neb-b Aug 9, 2018
@neb-b
Copy link
Author

neb-b commented Aug 9, 2018

@skhameneh This is ready for review. There are still two issues but I would like to get this merged now so we can get some more eyes on it since I changed a lot of styles across the app.

Known issues:

@lbry-bot lbry-bot assigned neb-b and unassigned skhameneh Aug 10, 2018
@neb-b neb-b merged commit 39b01b6 into master Aug 13, 2018
@neb-b neb-b deleted the next-video branch September 10, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants