added learn more faq to wallet security section #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ykris45
commented
Aug 28, 2018
ykris45
commented
neb-b
suggested changes
Aug 28, 2018
src/renderer/page/settings/view.jsx
Outdated
| @@ -348,12 +348,17 @@ class SettingsPage extends React.PureComponent<Props, State> { | |||
| name="encrypt_wallet" | |||
| onChange={e => this.onChangeEncryptWallet(e)} | |||
| checked={walletEncrypted} | |||
| postfix={__('Encrypt my wallet with a custom password.')} | |||
| helper={__( | |||
There was a problem hiding this comment.
We should still use this helper prop. You can just add the button at the end of it.
|
@seanyesmunt done |
|
@ykris45 how are you committing these changes, through the web interface? They should be submitted through git, so that formatting tools like prettier run on them. You can also run prettier locally in programs like Atom. |
neb-b
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.