issue 2015 #2016
Merged
issue 2015 #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imjayanthka thanks for the contribution! Can we send your some LBC in appreciation? |
|
sure |
|
Awesome! @imjayanthka Could you squash these into one commit? And also add changelog entry? Then we can merge it 🙂 |
|
sure give me a sec |
|
git commit scripts fail on flow focus-check --color always |
|
I'm guessing it's because some of these files have Flow errors. It's fine to ignore them for this PR, if we want to fix any that would be great too! For now you can do The |
imjayanthka
force-pushed
the
master
branch
2 times, most recently
from
c66b517
to
1fdca50
Compare
|
does this work? |
neb-b
reviewed
Oct 5, 2018
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
| ### Changed | |||
| * Make tooltip smarter ([#1979](https://github.com/lbryio/lbry-desktop/pull/1979)) | |||
| * Change channel pages to have 48 items instead of 10 ([#2002](https://github.com/lbryio/lbry-desktop/pull/2002)) | |||
|
|
|||
| * update to http ([#2016](https://github.com/lbryio/lbry-desktop/pull/2016)) | |||
|
Yep. Just a small typo |
|
@imjayanthka please don't forget to reach out to us so we send you some LBC in appreciation for the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated http to https