Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing existing colors with npm module, and refactored Sass #2045

Merged
merged 14 commits into from
Oct 22, 2018
Merged

Conversation

NetOpWibby
Copy link
Contributor

@NetOpWibby NetOpWibby commented Oct 16, 2018

This PR is unfinished, still have to go through the app and tweak.

@neb-b
Copy link

neb-b commented Oct 19, 2018

This is looking great. I really like the new font. I found a few issues and also have a few more generic comments.

  • The input borders are gone. It looks like it can't find the variable
  • The modal opacity makes it hard to read text actual content on the modal
  • It's hard to read the help text next to the search suggestion
  • The exact url match on the search page needs to be updated for the new dark mode
  • Input/label input color needs to be updated for dark mode
  • The table row headings are hard to see on dark mode, also the grey on grey text is hard to read on even numbered rows

@neb-b
Copy link

neb-b commented Oct 19, 2018

I'm not super sure about the new green color. I like the actual color but it's a lot harder to read buttons with white text. The contrast ratio is significantly lower than the previous combination which was already pretty low.

https://webaim.org/resources/contrastchecker/

@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Oct 19, 2018
@NetOpWibby
Copy link
Contributor Author

NetOpWibby commented Oct 19, 2018

@seanyesmunt Pushed up some changes. The $lbry-teal-5 color (#2f9176) is being used for all buttons now, due to its excellent contrast. It doesn't pass WCAG AAA though, only WCAG AA.

#1f614d passes all tests but it's also pretty dark.

@neb-b
Copy link

neb-b commented Oct 19, 2018

@NetOperatorWibby I don't think we have to pass all, teal-5 looks great. Way easier to read compared to teal-3

@neb-b
Copy link

neb-b commented Oct 19, 2018

The search page is looking better on dark mode. There are still some issues with placeholders.

The input background color is also a little tough to read on dark mode (both search and copyable inputs)
And the markdown input on the publish page

@NetOpWibby
Copy link
Contributor Author

Alright, fixed inputs. Found a rather interesting bug/feature. When you highlight text and then switch themes, the selected text is white and will not fix itself unless you reload the app.

@NetOpWibby
Copy link
Contributor Author

This is another good site for contrast testing: https://colorable.jxnblk.com/ffffff/2f9176

@neb-b
Copy link

neb-b commented Oct 22, 2018

A few last issues (I think)

The startup screen/snackbar/text highlighting should use teal-5 too

1 similar comment
@neb-b
Copy link

neb-b commented Oct 22, 2018

A few last issues (I think)

The startup screen/snackbar/text highlighting should use teal-5 too

color: var(--btn-external-color);
}
&.btn--disabled:disabled {
// wtf?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super sure if we need this but I think that was for specificity

@lbry-bot lbry-bot assigned NetOpWibby and unassigned neb-b Oct 22, 2018
@neb-b
Copy link

neb-b commented Oct 22, 2018

@NetOperatorWibby After looking at some of the code more closely I'm starting to think we should keep the vars file. That would avoid the need for using nested rules in the dark theme scss file.

Currently in some cases, if any layout changes, the dark mode would break.

@NetOpWibby
Copy link
Contributor Author

@seanyesmunt We lose the flexibility of using rgba functions and end up having more colors than necessary. I don't think layout changes are a strong argument. Dark mode would have to be checked out if changes are made regardless.

@neb-b
Copy link

neb-b commented Oct 22, 2018

@NetOperatorWibby Ah I didn't know we couldn't use rgba functions with that. Ok I'm fine with it. 👍

@NetOpWibby
Copy link
Contributor Author

@seanyesmunt Do I need to do anything else to get this merged?

@neb-b
Copy link

neb-b commented Oct 22, 2018

I think the only thing left I've noticed is the text in the search bar is really hard to read on light mode. After that is fixed I think we can merge this.

@NetOpWibby
Copy link
Contributor Author

Done

Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing there will be a few more things to fix before this is released but it's fine for now to begin testing.

@neb-b neb-b merged commit d0f03ee into master Oct 22, 2018
@NetOpWibby NetOpWibby deleted the redesign branch October 22, 2018 16:45
@NetOpWibby
Copy link
Contributor Author

Cool beans, I'll go through everything finely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants