Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Permanent URL Copy Fix #2168

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Full Permanent URL Copy Fix #2168

merged 2 commits into from
Jan 8, 2019

Conversation

QuirkyRobots
Copy link
Contributor

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: N/A

What is the current behaviour?

Copying a link only copies the community/vanity link on some claims, such as the Community Top Bid Area.

What is the new behaviour?

The fix makes sure the full permanent URL is always copied.

Other information

QuirkyRobots and others added 2 commits January 8, 2019 02:11
This change ensures the full permanent URL is copied and not just the vanity/community URL.
@neb-b neb-b merged commit 242b60c into lbryio:master Jan 8, 2019
@neb-b
Copy link

neb-b commented Jan 8, 2019

Thanks for the PR's @Invariant-Change 🙂

@QuirkyRobots
Copy link
Contributor Author

Your welcome @seanyesmunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants