Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up file{card,tile} for simpler small/large adjustments and better placeholder behavior #2280

Merged
merged 1 commit into from
Feb 15, 2019
Merged

clean up file{card,tile} for simpler small/large adjustments and better placeholder behavior #2280

merged 1 commit into from
Feb 15, 2019

Conversation

neb-b
Copy link

@neb-b neb-b commented Feb 14, 2019 •
edited
Loading

Changes

  • Add yrbl to search page when no content is found
  • More precise placeholders so there is no content jumping
  • Cleaned up a lot of styles in _media.scss with two main goals
    • Less complicated nesting of styles
    • Easier to reason about font sizes for cards/tiles

screen shot 2019-02-13 at 11 51 34 pm

@neb-b neb-b force-pushed the search-ux branch 2 times, most recently from c631189 to b9130dc Compare February 14, 2019 21:19
@neb-b neb-b changed the title [WIP] Search UX improvements clean up file{card,tile} for simpler small/large adjustments and better placeholder behavior Feb 14, 2019
@neb-b neb-b requested a review from skhameneh February 14, 2019 21:24
@lbry-bot lbry-bot assigned skhameneh and unassigned neb-b Feb 14, 2019
@neb-b neb-b merged commit 7d8f83b into master Feb 15, 2019
@neb-b neb-b deleted the search-ux branch March 11, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhameneh skhameneh skhameneh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neb-b @skhameneh