Discovery UI #2477
Discovery UI #2477
Conversation
|
Attempted to run the
|
|
I will be making a number of changes to this branch today as I wire up redux. |
neb-b
force-pushed
the
discovery
branch
2 times, most recently
from
3036074
to
6064bef
Compare
| @@ -12,6 +12,7 @@ | |||
| <meta property="og:description" content="All your favorite LBRY content in your browser." /> | |||
| <meta property="og:image" content="/og.png" /> | |||
| <!-- @endif --> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
There was a problem hiding this comment.
@kauffj You said not to build a mobile layout, but you didn't say not to create a new desktop layout that just happens to look good on mobile too.
src/ui/component/fileList/view.jsx
Outdated
| ) : ( | ||
| header | ||
| )} | ||
| <div className="file-list__sort">{sort}</div> |
There was a problem hiding this comment.
Not really a fan of sort. This is the item on the right side of the header. Currently the two pages that use this are the homepage (trending/best/new) and search feedback (satisfied with results?)
Sort isn't really a good name.
There was a problem hiding this comment.
headerAltControls? headerSecondaryControls? or same names without the word header?
neb-b
force-pushed
the
discovery
branch
3 times, most recently
from
2aace2f
to
9e4a5b9
Compare
src/ui/component/fileList/view.jsx
Outdated
| ) : ( | ||
| header | ||
| )} | ||
| <div className="file-list__sort">{sort}</div> |
There was a problem hiding this comment.
headerAltControls? headerSecondaryControls? or same names without the word header?
| uris={trending} | ||
| injectedItem={personalSort === TRENDING_SORT_YOU && injectedItem} | ||
| header={ | ||
| <React.Fragment> |
There was a problem hiding this comment.
Should this just be a component? Or at least not inlined? Same for the sort parameter below
There was a problem hiding this comment.
👍 I pulled it out. Possibly there should be FileListHeader component, but I think it helps to keep this logic here, since all of this is related.
| <FileListTrending | ||
| personal | ||
| tags={followedTags.map(tag => tag.name)} | ||
| injectedItem={<TagsSelect showClose title={__('Make This Your Own')} />} |
There was a problem hiding this comment.
Mildly uncertain about the pattern of relying on the local persisted state of <TagsSelect> being closed to not re-render this. I suppose that is fine though.
There was a problem hiding this comment.
Yeah I wasn't really sure about this. Another option is to always show the injected item. It could be in the third/fourth position if there are more than four items, otherwise, just show at the end.
I figured we would have another on the subscriptions page somewhere.
| const hasDownloads = !!downloadedUris.length; | ||
| console.log('downloadedUris', downloadedUris); | ||
| return ( | ||
| // Removed the <Page> wapper to try combining this page with UserHistory |
There was a problem hiding this comment.
Per comments in Slack, I'm fine with dropping the history, at least temporarily, if that makes this easier/cleaner
There was a problem hiding this comment.
It would, and I'm fine with that for now. I'll remove it/make the other changes in the next PR
| location: { search }, | ||
| } = props; | ||
|
|
||
| const urlParams = new URLSearchParams(search); |
neb-b
force-pushed
the
discovery
branch
2 times, most recently
from
e09232d
to
fd9bfa6
Compare
Changes
FileListItemNotes
.scssfiles for now. I need to make a PR to github.com/lbryio/color before the styles are complete.