crude i18n support #2539
Merged
crude i18n support #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kauffj
commented
Jun 7, 2019
src/ui/component/app/view.jsx
Outdated
| <Header /> | ||
| <SideBar /> | ||
| <Header language={language} /> | ||
| <SideBar language={language} /> |
There was a problem hiding this comment.
@seanyesmunt I did this to trigger re-renders when the language changes. Is this the proper way to do this [given the __ function is not a React component]?
There was a problem hiding this comment.
At this moment menu not work :)
There was a problem hiding this comment.
Discussed on the standup, but I would move these to {header, sideBar}/index.js
neb-b
reviewed
Jun 10, 2019
src/ui/component/app/view.jsx
Outdated
| theme: string, | ||
| updateBlockHeight: () => void, | ||
| toggleEnhancedLayout: () => void, | ||
| enhancedLayout: boolean, | ||
| }; | ||
|
|
||
| class App extends React.PureComponent<Props> { | ||
| componentWillMount() { | ||
| // eslint-disable-next-line | ||
| UNSAFE_componentWillMount() { |
There was a problem hiding this comment.
This can be changed to componentDidMount
neb-b
approved these changes
Jun 10, 2019
src/ui/component/app/view.jsx
Outdated
| <Header /> | ||
| <SideBar /> | ||
| <Header language={language} /> | ||
| <SideBar language={language} /> |
There was a problem hiding this comment.
Discussed on the standup, but I would move these to {header, sideBar}/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic language selector, stores the language setting, refreshes the UI on change, and adds the first polish language file.
Much of this should be improved for multiple language support and so there is a better ongoing workflow, but this should help @Madiator2011 continue his work (@jsigwart).