Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported yrbl #2834

Merged
merged 3 commits into from
Sep 4, 2019
Merged

unsupported yrbl #2834

merged 3 commits into from
Sep 4, 2019

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Sep 2, 2019

App/Web - specific messages for unsupported content handling cases in Viewer and ViewerInitiator.

Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple comments. We should link to lbry.com/get whenever we say to download the app.

<div className={'content__cover--disabled'}>
<Yrbl
className={'content__cover--disabled'}
title={'Not available on LBRY TV'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lbry.tv

<Yrbl
className={'content__cover--disabled'}
title={'Not available on LBRY TV'}
subtitle={'You can view or download this file by installing the App'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can view this content in the LBRY app. <Button label={"Download it here"} href="lbry.com/get"...

@neb-b neb-b merged commit ed05959 into master Sep 4, 2019
@neb-b neb-b deleted the unsupportedYrbl branch October 15, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants