Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stores and recalls volume #2934

Merged
merged 2 commits into from
Oct 3, 2019
Merged

stores and recalls volume #2934

merged 2 commits into from
Oct 3, 2019

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Sep 28, 2019

No description provided.

@jessopb jessopb requested a review from neb-b September 28, 2019 03:45
@lbry-bot lbry-bot assigned neb-b and unassigned jessopb Sep 28, 2019
neb-b
neb-b suggested changes Sep 30, 2019
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to re-mount the video component the first time you change the volume.

Changing it again after the first time works well, but it resets the video to the beginning after you change it initially

@lbry-bot lbry-bot assigned jessopb and unassigned neb-b Sep 30, 2019
@jessopb jessopb requested a review from neb-b September 30, 2019 20:18
@lbry-bot lbry-bot assigned neb-b and unassigned jessopb Sep 30, 2019
@jessopb
Copy link
Member Author

jessopb commented Sep 30, 2019

This appears to re-mount the video component the first time you change the volume.

Changing it again after the first time works well, but it resets the video to the beginning after you change it initially

Ok, I removed muted and volume from the useEffect deps. On my test, I didn't experience any hiccups. Try again?

@tzarebczan
Copy link
Contributor

If there's time and this works, let's try to get it into the next release.

@tzarebczan
Copy link
Contributor

This LGTM!

@neb-b neb-b merged commit 879cba7 into master Oct 3, 2019
@neb-b neb-b deleted the volume branch October 15, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b Awaiting requested review from neb-b

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessopb @tzarebczan @neb-b