Enhance file remove modal #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll give this a closer review once we release 0.37 |
Ideally some time yet in October? |
|
Yep! We’re releasing today
On Thu, Oct 17, 2019 at 11:59 AM Brent Clark ***@***.***> wrote:
Thanks! I'll give this a closer review once we release 0.37
Ideally some time yet in October?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3069?email_source=notifications&email_token=AEAZZDV5QL5INM2GMFCSNJLQPCDUPA5CNFSM4JBS7FX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQTZEY#issuecomment-543243411>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAZZDQVVAAK5ZJK5YQHD7DQPCDUPANCNFSM4JBS7FXQ>
.
--
Sean Yesmunt
Engineer for lbry.com
|
|
@brentmclark, thanks for the PR! Congrats on the first one here :) Can we show you some appreciation for the contribution? Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll send you the information when you reach out to us. |
|
Thank you @tzarebczan! |
neb-b
suggested changes
Oct 22, 2019
| <div> | ||
| <FormField | ||
| name="claim_abandon" | ||
| label={`${__('Abandon on blockchain')} (${__('reclaim')} ${claim.amount} ${__('LBC')})`} |
There was a problem hiding this comment.
To work better with other language strings, this should be:
__("Abandon on blockchain (reclaim %amount% LBC)", { amount: claim.amount })
There was a problem hiding this comment.
That makes sense to me. Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
ImprovementFixes
Issue Number: #895
What is the current behavior?
Checkboxes with undesirable copy and no warning when the claim is not selected for removal.
What is the new behavior?
Checkboxes with desired copy and a warning when the claim is not selected for removal.
New UI
With checkbox unchecked