Update documentation for DevTools and fix some ESLint warnings #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 27, 2017 20:48
IGassmann
changed the title
IGassmann
changed the title
liamcardenas
suggested changes
Dec 28, 2017
README.md
Outdated
|
|
||
| ### Ongoing Development |
There was a problem hiding this comment.
Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
There was a problem hiding this comment.
ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
There was a problem hiding this comment.
I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
Ruk33
pushed a commit
that referenced
this pull request
Feb 25, 2022
…#911) ## Issue 535 ## Change - Header: Use the "channel list undefined" instead of "active channel url undefined" to determine if the button should be "pending". - App: restore the use of `activeChannelClaim` instead of `activeChannelId`. In the existing design, the latter is never cleared is some situations, so the former is more accurate as it takes the current channel list into account. We might want to hide (not export) `activeChannelId` to avoid this mis-use again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ESLint warnings concerning anonymous functions and updates the documentation for the project's DevTools.