Redesign groundwork #935
Merged
Redesign groundwork #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruk33
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Move into getLocalStorageSummary + always log - Move into getLocalStorageSummary to clean up the clutter. - Always log the localStorage info to get a bigger picture of what's going on with the QuotaExceededError. * Remove 'findPreviousUploads' - we use the url stored in Redux. Something I forgot to remove in the past. It also reads from localStorage, so remove since we are trying to avoid touching localStorage. * Ensure localStorage is not used when uploading I don't think it's being written when `storeFingerprintForResuming` is disabled, but doing the suggestion nonetheless. `https://github.com/tus/tus-js-client/issues/315#issuecomment-1046821112`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #870
Didn't realize that PR was merging to master. Reverted and now correctly merging to
redesign