Refactor Electron's main process #951
Conversation
|
@alexliebowitz I think a decent portion of this code was originally yours, it'd be good to get your eyes on this changeset. |
|
I agree, everything looks good here to me but it would be gret to get Alex's take. I am ready to merge if Alex gives the thumbs up |
| let URI; | ||
| if (process.platform === 'win32' && String(argv[1]).startsWith('lbry')) { | ||
| // Keep only command line / deep linked arguments | ||
| URI = argv[1].replace(/\/$/, '').replace('/#', '#'); |
There was a problem hiding this comment.
Hmm, now we're doing this same substitution in two places instead of in one function. That feels brittle (what if we find another problem with Windows URI handling and don't realize it's there in two places), and also
We might want to move this back into its own function, or at least add another comment here. Just a thought.
| } | ||
| }); | ||
|
|
||
| window.webContents.on('crashed', () => { |
There was a problem hiding this comment.
It doesn't seem like this event is actually sent on the renderer side. Did you mean to build that, or is it something we're going to add later?
There was a problem hiding this comment.
It's necessary to handle it: https://electronjs.org/docs/api/web-contents#event-crashed
| import path from 'path'; | ||
| import createWindow from './createWindow'; | ||
|
|
||
| export default class Tray { |
There was a problem hiding this comment.
Does this need to be a whole object? create() is only called once and it doesn't need any state, so maybe just a createTray function that takes an updateAttachedWindow callback?
There was a problem hiding this comment.
I went for a exported createTray() function initially. However, since it also needs to manage the state of the window, I finally went for using a class.
This closes #938, closes #298 and fixes #298.