Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate exporting API documentation to Swagger format #1203

Closed
kauffj opened this issue May 15, 2018 · 7 comments
Closed

Investigate exporting API documentation to Swagger format #1203

kauffj opened this issue May 15, 2018 · 7 comments
Assignees
Labels
area: docs level: 1 No knowledge of the existing code required

Comments

@kauffj
Copy link
Member

kauffj commented May 15, 2018

(This ticket is possibly under- or incorrectly specified since I don't know very much about Swagger.)

lbry.tech will need to display the API documentation for lbry, lbrycrd, and potentially other projects like lighthouse.

Having all repositories that provide an API export their API signatures in a shared, open format will allow lbry.tech to display all APIs in a similar fashion.

@kauffj kauffj added level: 1 No knowledge of the existing code required area: docs labels May 15, 2018
@lyoshenka lyoshenka added this to the May 28 (protocol) milestone May 15, 2018
@hackrush01
Copy link
Contributor

Next Steps

  • Check what the output format for the documentation should be
  • Assess the difficulty for changing the current one

@lyoshenka lyoshenka changed the title Export API documentation to Swagger format Investigate exporting API documentation to Swagger format May 15, 2018
@tiger5226
Copy link
Contributor

As a reference, just in case it is useful, swagger documentation is used for chainquery here. It is not complete yet but might be helpful.

Also it can be done really easily now with the open api designer

@lyoshenka
Copy link
Member

My understanding was that Swagger does not support JSONRPC, only REST. Is that true? Maybe that's not true anymore?

@tiger5226
Copy link
Contributor

OAI/OpenAPI-Specification#801
Looks like it didn't get into 3.0 spec.

@lyoshenka
Copy link
Member

lyoshenka commented May 25, 2018 via email

@tiger5226
Copy link
Contributor

No I could not find anything on the status of that. There was communication where people said they hacked it in, but I didn't think we would want follow suite there.

@lyoshenka
Copy link
Member

bitshares is having the same issue: bitshares/bitshares-core#792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs level: 1 No knowledge of the existing code required
Projects
None yet
Development

No branches or pull requests

6 participants