Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pull request on how to submit a pull request #1

Merged
merged 1 commit into from
Aug 22, 2015

Conversation

edwardjkim
Copy link
Contributor

I put the main file in CONTRIBUTING.md, but not sure exactly where this belongs, so I'm sending this as a PR to start a discussion. Also meta.

Perhaps this belongs in the Wiki, or in intro2github.ipynb as an optional material since we are not covering Git this semester. Maybe we can just provide the link to CONTRIBUTING.md whenever the issue comes up.

@ProfessorBrunner
Copy link
Contributor

We technically covered git in the orientation week! So I might just say to do that this week as well. Although really all they need is git clone to get the course repo. If students want to use git for their own homework, we can't stop them, but we also don't have to push it on them.

So 1) if this is in the Wiki I don't know how to put it there. It might be nice to have an initial wiki entry. And this is good in showing how to fix problems in the repo. But you have private in all images, so we probably should do the screenshots after I open? But if it is in the wiki, will we lose it when we make a new course?

@edwardjkim
Copy link
Contributor Author

Yes, I should fix the screenshots after we open. And it's fortunate that we chose Github Wiki because it works with Git. I can just do

$ git clone https://github.com/YOUR_USERNAME/YOUR_REPOSITORY.wiki.git

and it's cloned. Note the extra wiki at the end between YOUR_REPOSITORY and git.

https://help.github.com/articles/adding-and-editing-wiki-pages-locally

We can also do all things git: make changes, commit, and push. So anything in the Wiki can easily be carried over to the next course.

@edwardjkim
Copy link
Contributor Author

Merging this, and putting a link to this guide in the Wiki.

edwardjkim added a commit that referenced this pull request Aug 22, 2015
A pull request on how to submit a pull request
@edwardjkim edwardjkim merged commit 5d2f92f into lcdm-uiuc:master Aug 22, 2015
@edwardjkim edwardjkim deleted the pull_request_guide branch August 23, 2015 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants