NoritakeVFD Patch Cursor #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The positioning of the cursor was not working correctly. Beside other fixes the rows and columns were inverted in the initial code. Tested with CU20045SCPB-T31A.
haraldg
reviewed
Dec 18, 2016
| @@ -412,7 +412,7 @@ NoritakeVFD_chr (Driver *drvthis, int x, int y, char c) | |||
| * \param string String that gets written. | |||
| */ | |||
| MODULE_EXPORT void | |||
| NoritakeVFD_string (Driver *drvthis, int x, int y, const char string[]) | |||
| NoritakeVFD_string (Driver *drvthis, int x, int y, unsigned char string[]) | |||
| { | |||
There was a problem hiding this comment.
It should be "const unsigned char" at least. However the API documentation quite clearly requires "const char" - maybe this is a bad idea. But then we should change this properly.
There was a problem hiding this comment.
I just took this change from another driver.
But I can update the commit and test the corrections by the end of next week.
|
@hoblins Are you going to update or comment this PR? I want to merge this PR before I tag the release and would edit this patch myself if you are not working on it. |
|
Made changes remarked by haraldg and tested with CU20045SCPB-T31A. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positioning of the cursor was not working correctly. Beside other fixes the rows and columns were inverted in the initial code.
Tested with CU20045SCPB-T31A.